fix issue with spatie/laravel-backup v9
#147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this ? Would be nice if this branch could be merged soon. |
|
Any updates on this ? |
|
Hi guys, can you please merge this branch? It's a bit annoying we can' upgrade :) |
|
@freekmurze Any possibility to do something ? |
|
This would be greatly appreciated if it gets merged :) |
freekmurze
requested changes
Nov 18, 2024
move logic to method
|
Same issue here, please fix asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue with
spatie/laravel-backupv9 who use DTO forBackupDestinationStatusFactory::createForMonitorConfiginstead of array and allow usage of v9 with DTO, or ≤ v8 with array.Error with
spatie/nova-backup-toolv5.0.8 andspatie/laravel-backupv9 :local.ERROR: Spatie\Backup\Tasks\Monitor\BackupDestinationStatusFactory::createForMonitorConfig(): Argument #1 ($monitorConfiguration) must be of type Spatie\Backup\Config\MonitoredBackupsConfig, array given, called in /Users/tof/Herd/Nova/vendor/spatie/nova-backup-tool/src/Http/Controllers/BackupStatusesController.php on line 15 {"userId":1,"exception":"[object] (TypeError(code: 0): Spatie\\Backup\\Tasks\\Monitor\\BackupDestinationStatusFactory::createForMonitorConfig(): Argument #1 ($monitorConfiguration) must be of type Spatie\\Backup\\Config\\MonitoredBackupsConfig, array given, called in /Users/tof/Herd/Nova/vendor/spatie/nova-backup-tool/src/Http/Controllers/BackupStatusesController.php on line 15 at /Users/tof/Herd/Nova/vendor/spatie/laravel-backup/src/Tasks/Monitor/BackupDestinationStatusFactory.php:14)