Fix toArray when using accessors on translatable attributes #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like the tests are failing, could you take a look? |
|
It should be fixed now. The expectation I was using was added lately, it failed on older pest versions. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When using accessors on translatable attributes, the
toArraymethod doesn't work like expected.Normally when you get the value of an attribute, the accessor gets the translated value as its parameter. When using
toArrayon the model the accessor gets the raw value instead.I've added a test to reproduce the issue.
This change only affects translated attributes with accessors, the
mutateAttributeForArraymethod gets called only for attributes with accessors defined.