Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Keep null value" #428

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Revert "Keep null value" #428

merged 1 commit into from
Dec 6, 2023

Conversation

mabdullahsari
Copy link
Contributor

Hi 👋

This PR reverts the changes made in the original PR. Even though I am a proponent of the suggested changes, unfortunately it's a breaking change for people who don't make use of type juggling through the use of declare(strict_types=1).
Moreover, this is also going to break the code of those who are on the most recent PHP versions where str_* functions no longer accept null as a legitimate value.

The suggested changes should be targeted at a v7 or a next branch, ideally.

Thank you 🙏

This reverts commit abecffc.
@freekmurze
Copy link
Member

freekmurze commented Dec 6, 2023

Thank you! I'm going to treat this as a bug fix, and release it under the current major version.

@freekmurze freekmurze merged commit d6dc7c9 into spatie:main Dec 6, 2023
11 checks passed
@sdebacker
Copy link
Contributor

Does it mean that a new major version will be created that keeps the null values ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants