Add Set Icon and Username ability; add missing onQueue declaration #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add tests for this one at well? |
|
@freekmurze fixed an icon_url reference and added tests. I cannot figure out how to run tests against the items in vendor/tests, so am unable to verify them. But if they run for you, we should be good. I have the current changes working in my dev environment here. |
|
Seems like the tests are failing. Could you take a look? |
|
Thanks! |
Awesome, thank you! |
1 similar comment
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the need to set the slack Display Name, and icon next to it, when my application posts into my alert channel; this code adds it, and updates the README for it.
It also adds a missing declaration for
onQueuewhich was causing my IDE to not know that it was there.