Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowedFilter should return static rather than self #964

Merged

Conversation

kosarinin
Copy link

Hey, everyone!

Thanks for this fantastic project. We find it very useful in our projects.

In our project, we want to extend the AllowedFilter class, and it seems nothing prevents us from doing that with the only exception - all methods return self and not static.

Please consider merging these changes.

I appreciate your work on this project!

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit f3c7828 into spatie:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants