Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static return type when returning $this #775

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

lorenzolosa
Copy link
Contributor

I've changed the return types of some chainable methods in QueryBuilder from self to static, as it's more precise.

I've noticed this as I'm extending the QueryBuilder class with an additional method.

@freekmurze freekmurze merged commit b3e8e12 into spatie:main Jun 6, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants