Laravel 9 lang folder location

[voicecode-bv]

No description provided.

[freekmurze]

Seems like the tests are failing for this one. Could you take a look?

[riasvdv]

There's been a lang_path function since Laravel 8.x, is it possible to use that one instead? Maybe we can drop support for Laravel 7.x as well?

[freekmurze]

Using lang_path is probably the way to go. We use laravel-package-tools for packages of our own that need to support older Laravel versions (such as ray).

[voicecode-bv]

@freekmurze Updated the PR using the lang_path helper. Funny... I was not aware of the helper, it doesn't seem to be in the docs too.

[voicecode-bv]

Thanks @danilopolani! I've updated the path.

[freekmurze]

Seems like Laravel 7 and lower do not have a lang_path function. Could you solve this by using the old lang path if we detect Laravel 7 or below?

[riasvdv]

Just a method_exists('lang_path') should work for detecting it

[freekmurze]

@riasvdv that could work, but I think a Laravel version check could be better as it better communicates why lang_path does not exist.

But I have no strong opinion on it, @voicecode-bv: you can do what you prefer.

[voicecode-bv]

@freekmurze @riasvdv I had the feeling I needed to research when the lang_helper function was added, and I think I found it here. It seems like earlier versions of Laravel 8 also don't have the helper function. So I've added a 8.64 version check.

[danilopolani]

At this point wouldn't be easy to just stick with the standard app()->langPath() / $this->app->langPath()? It's present in L7 and even L6, so you don't need to do magic version checks (?)

[voicecode-bv]

@danilopolani if this works, it works. If another way is desired, please open another PR. Feels like this is taking too much time already :)

[freekmurze]

It works! Thanks for your work on this! 👍