-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 9 lang folder location #48
Conversation
Since Laravel 9 the lang folder has been moved outside the resources folder. Using the version compare method the target folder will be set to support older versions of Laravel.
Seems like the tests are failing for this one. Could you take a look? |
There's been a |
Using |
@freekmurze Updated the PR using the lang_path helper. Funny... I was not aware of the helper, it doesn't seem to be in the docs too. |
Thanks @danilopolani! I've updated the path. |
Seems like Laravel 7 and lower do not have a |
Just a |
@riasvdv that could work, but I think a Laravel version check could be better as it better communicates why But I have no strong opinion on it, @voicecode-bv: you can do what you prefer. |
@freekmurze @riasvdv I had the feeling I needed to research when the lang_helper function was added, and I think I found it here. It seems like earlier versions of Laravel 8 also don't have the helper function. So I've added a 8.64 version check. |
At this point wouldn't be easy to just stick with the standard |
@danilopolani if this works, it works. If another way is desired, please open another PR. Feels like this is taking too much time already :) |
It works! Thanks for your work on this! 👍 |
No description provided.