Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt attribute to responsive image components #3765

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

A909M
Copy link
Contributor

@A909M A909M commented Jan 11, 2025

Description

This PR adds the missing alt attribute to the responsiveImage and responsiveImageWithPlaceholder components. When not explicitly provided, the alt attribute defaults to the media's name, improving accessibility and usability.

@A909M
Copy link
Contributor Author

A909M commented Jan 11, 2025

References

@freekmurze
Copy link
Member

It seems the tests are failing, could you take a look at that?

@A909M
Copy link
Contributor Author

A909M commented Jan 13, 2025

I updated the test.

@freekmurze

@freekmurze freekmurze merged commit 8372552 into spatie:main Jan 13, 2025
1 of 13 checks passed
@freekmurze
Copy link
Member

Thanks!

@A909M A909M deleted the add-alt-attribute branch January 13, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants