Correctly search media conversion by name #3715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
ConversionCollection
's behavior in finding conversion by name.If a subject model has multiple collections, and multiple conversions with the same name, but applied to different collections, then
ConversionCollection
incorrectly determines the conversion which should be applied to the media.Example:
Now, whereas conversion files are generated correctly, their URLs and paths are wrong, because
ConversionCollection
doesn't honor media collection, getting just the first conversion which name matches:Result:
Generated URL is wrong too, because internally the fetched conversion is used to determine file extension:
Result:
This PR fixes this behavior. Specifically,
ConversionCollection::getByName()
function first filters conversions by media's collection, and only then searches by conversion name.Tests included.