Fix deletion of files without extension #3664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing in Laravel apps when using fake images generated by
UploadedFile::fake()->image('image.jpg')
as the file will be generated internally bytmpfile()
and will be named (E.g.)phpGoZkJ9
Currently, it looks if the path contains the filename, including the dot:
phpGoZkJ9.
I changed it to match the full filename after the forward slash
/
From my understanding, the
$path
will always have a forward slash (/
) before the filename.If there's a case where doesn't have a forward slash or uses double backslashes
\\
(because Windows),I will happily update my PR to include corresponding scenarios and tests.Thanks!