Do not limit the maximum execution time if the queue connection is "sync" #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time if the queue connection is "sync".
freekmurze
requested changes
May 22, 2024
| return; | ||
| } | ||
|
|
||
| $mediaFiles = $this->getMediaToBeRegenerated(); | ||
|
|
||
| $progressBar = $this->output->createProgressBar($mediaFiles->count()); | ||
|
|
||
| if (config('media-library.queue_connection_name') == 'sync') { |
There was a problem hiding this comment.
could you make this a strict check?
I'm sorry. I didn't see that code style had changed. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When regenerating the conversions and if the queue connection is set to "sync", the jobs are not handled "asynchronously". So the execution time can be very long depending on the number of medias to handle. And in some cases, the script reached the maximum execution time defined in php.ini and exit with an error code.
This PR disable the maximum execution time if the queue connection is "sync".