Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defining-conversions.md #3544

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Update defining-conversions.md #3544

merged 1 commit into from
Feb 17, 2024

Conversation

misaf
Copy link
Contributor

@misaf misaf commented Feb 17, 2024

According to the definition of the method in the HasMedia interface, Media should be nullable in the registerMediaConversions method. However, in the documentation, it is represented as 'should not be null.' I have corrected them.

@freekmurze freekmurze merged commit 30093e6 into spatie:main Feb 17, 2024
1 check passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants