Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image v3 #3451

Merged
merged 40 commits into from
Dec 14, 2023
Merged

Use image v3 #3451

merged 40 commits into from
Dec 14, 2023

Conversation

freekmurze
Copy link
Member

No description provided.

@freekmurze freekmurze merged commit a1823c0 into main Dec 14, 2023
10 checks passed
@freekmurze freekmurze deleted the v11 branch December 14, 2023 14:18
@cosmastech
Copy link
Contributor

@freekmurze previously, using \Storage::fake('local') would prevent test files from being created. It seems like there's some kind of regression here, not sure if it's with Image v3 or this PR. After running tests now, we have files being created at ./storage/media-library/temp/bTicW6ce5DddWYO3ASVwthRi29688BmM/RLBed4mV4XYy6uAMZPOGykJEWdqd7QZAthumb.jpg

Luckily it's not breaking our pipelines, just a slight annoyance 😆

@freekmurze
Copy link
Member Author

I'm sorry that the upgrade is causing (minor) troubles. The test suites of stuff still seems to work.

As always, I'm open for PR to fix things that go wrong on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants