Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing public function signatures from InteractsWithMedia to HasMedia interface #3431

Closed
wants to merge 1 commit into from
Closed

Added missing public function signatures from InteractsWithMedia to HasMedia interface #3431

wants to merge 1 commit into from

Conversation

korridor
Copy link
Contributor

@korridor korridor commented Nov 2, 2023 •
edited
Loading

Fixes #3426

@freekmurze
Copy link
Member

Modifying interfaces is potentially a breaking change. I'll take a look again when creating the next major version of this package.

@freekmurze freekmurze closed this Nov 2, 2023
@korridor
Copy link
Contributor Author

korridor commented Nov 2, 2023

@freekmurze Would it be ok if I create PHPdocs for those functions instead?

@DanielGSoftware
Copy link

DanielGSoftware commented Jun 14, 2024 •
edited
Loading

@freekmurze the next major version was 1 month after this issue, but it's not been addressed.. what is the current status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korridor @freekmurze @DanielGSoftware