-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new custom delete fix #3190 #3252
Conversation
Signed-off-by: Ben James <[email protected]>
…h generator class Signed-off-by: Ben James <[email protected]>
Signed-off-by: Ben James <[email protected]>
Signed-off-by: Ben James <[email protected]>
This will be great. I was extremely confused why my entire media library was disappearing... 😩 |
It will take a long time for this to be solved? |
Do you have any news about this feature? |
@freekmurze I believe the requests were addressed in April. Let me know if you need anything else. |
This seems pretty nice! Could you also write docs on this? |
Any updates on this? |
Awaiting @freekmurze approval I believe. I am happy to write docs on it |
This is looking very good. Could you also add docs for it? |
Signed-off-by: Ben James <[email protected]>
@freekmurze I have added a new docs MD file to detail the new functionality |
It looks like these tests are failing due to this: #3417 |
Thanks! |
This adds a test, using a custom path generator which uses a shared folder (i.e. not individual /1/ folder per image)
Once the test was failing, I extracted out the 'removeFile' and 'removeAllFiles' logic into a FileRemover class using a FileRemover Factory, to work in the same way you currently swap out path generators.
I then added a new FileBasedFileRemover class, which fixes the failing test created to demonstrate #3190.
This PR allows:
These are split into 3 commits to see each part.