Fix data corruption bug when storage disk becomes invalid #3139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when a storage disk becomes invalid. The FileAdder.php#L450 would "redo" already saved records in DB, unfortunately, the produced SQL delete query scopes to all media belonging to a model (not by id).
While
$model->media()->delete($media->id)
call looks ok, for some reason it actually ignores specific media id and scopes to all.The was already a test case for this scenario, but it would run on the assumption there are no other media attached. So it would produce a false positive outcome.
Sample delete query before:
Sample delete query after: