Update FileAdder.php #3031
Closed
Update FileAdder.php #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the default filename sanitizer to handle funky whitespace characters in files - I had a case where a file was being uploaded, and it kepts throwing Flysystems `CorruptedPathDetected` exception. Not sure if copy-pasting the filename to github keeps the characters there: `Scan-9.14.2022-7.23.28.pdf`
|
Could you add a test for this? |
|
Hey @tommica, I'm just following up on the request by @freekmurze - are you able to add some unit tests for this PR? Thanks! |
|
No, sorry - I totally forgot about it, and got busy with other work.
|
patinthehat
added a commit
that referenced
this pull request
Nov 22, 2022
patinthehat
added a commit
that referenced
this pull request
Nov 22, 2022
freekmurze
pushed a commit
that referenced
this pull request
Nov 22, 2022
* Update FileAdder.php Update the default filename sanitizer to handle funky whitespace characters in files - I had a case where a file was being uploaded, and it kepts throwing Flysystems `CorruptedPathDetected` exception. Not sure if copy-pasting the filename to github keeps the characters there: `Scan-9.14.2022-7.23.28.pdf` * add unit tests for PR #3031 * Fix styling Co-authored-by: Tommi Carleman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the default filename sanitizer to handle funky whitespace characters in files - I had a case where a file was being uploaded, and it kepts throwing Flysystems
CorruptedPathDetectedexception. Not sure if copy-pasting the filename to github keeps the characters there:Scan-9.14.2022-7.23.28.pdf