Update CleanCommand to delete depreciated responsive images #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `php artisan media-library:clean` we should be clearing responsive images for conversions that are no longer used, as well as for active conversions that are no longer using responsive images. Fixes spatie#2397
|
Could you also update the tests, so we don't break this functionality in the future? |
michaellindahl
force-pushed
the
patch-1
branch
from
4a5738a to
a99b27a
Compare
|
@freekmurze Added a unit test for this and also deleted the duplicate unit test / file. Based on the structure of the existing CleanConversionsTest this seemed like the right thing to do. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
php artisan media-library:cleanwe should be clearing responsive images for conversions that are no longer used, as well as for active conversions that are no longer using responsive images. Fixes #2397