Fix media-library:clean command when using custom path generators
#2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Will this make it into v9 or older versions dont get support ? |
|
We don't actively support the older versions anymore, but we would still accept and merge PRs for bug fixes. |
|
😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2922 that I opened myself (this is a personal account, the account used to open the PR is my professional account).
Two modifications were done in this PR:
1.
The path generator used by the
media-library:cleancommand is now dynamically created in thedeleteConversionFilesForDeprecatedConversionsmethod for each processed media using the PathGeneratorFactory.This modification allows custom path generators configured via the
media-library.custom_path_generatorsto actually be used by the command and not only the DefaultPathGenerator included in this package, and consequently for conversions saved in custom path to be properly deleted.2.
Following this change, another issue came to light where the original image would be deleted if the path for conversions is configured to be the same as the original image path.
A new check was added to the
deleteConversionFilesForDeprecatedConversionsmethod to ensure that the original image is not mistakenly considered as a deprecated conversion and deleted.Side note: This is my first PR to open source project and I'm not really familiar with tests, so I hope the changes included in this PR are satisfying enough.