-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix responsive url generation #2852
Conversation
@freekmurze Hey 👋🏼 I think the tests need updating, am I right? I tested it locally on an app (L9 - ML10) that relies heavily on media-library, and everything seems to be working fine with the S3 disk. The localhost portion is probably omitted everywhere because it is the local disk, and thus does not really require an absolute URL. How do I proceed? |
The tests indeed need updating. If you want, go ahead and already do that. If not I'll update them later this week. |
I'll update them no problems. Just wanted to make sure. Thanks! |
I guess all of the code analysis failures are unrelated to my changes. |
Yeah, I'll fix those myself, no worries! |
The tests are OK! |
Thank you! |
Tyvm for merging 🙏 Could you release this as a patch please? 😇 |
Can this be merged into v10 too? |
done!
Freek Van der Herten
https://spatie.be
…On 24 Mar 2022 at 13:55:37, Muhammed Sari ***@***.***> wrote:
Thank you!
Tyvm for merging 🙏
Could you release this as a patch please? 😇
—
Reply to this email directly, view it on GitHub
<#2852 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADWEDOIMVIB2VI2SW4MK7DVBRQ4TANCNFSM5RHKL42A>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This is a duplicate of #2837 that fixes the issue for v10.
Closes #2778.