Remove the need for a TemporaryDirectory when copying media

[ghost]

Background

When using the media library pro package (livewire) to upload files directly to AWS S3 the process is like this:

1. generate temporary upload url (livewire)
2. upload file from users computer to AWS S3 (livewire)
3. A temporary upload is created (livewire)
4. The livewire temporaryUpload is moved into the media-library folder structure (media-library-pro)
5. A temporary media model is created (media-library-pro)

When the submit button is pressed to save the Media item the following happens:

1. The temporary media model is retrieved (media-library-pro)
2. The final location for the saved media is determined (media-library-pro)
3. The file is copied to a temporary directory on the Laravel server from the AWS S3 storage (media-library)
4. The temporary file is then re-uploaded to its permanent storage location (The same AWS S3 instance in this case) (media-library)
5. The new permanent media model is saved (media-library)

Problem: Large Files

We will be uploading large files to our AWS S3 (2-4 files about .8-1GB each). The current setup using the media library package means there is a whole extra download and upload step which makes this whole scenario take way more time than it needs to.

Solution

To remove the need for this extra copy step I propose these changes to the way media library items are copied and moved.

If the media item is on a remote file storage disk and is moving to the same file storage disk then we will use the internal Storage::move() functionality with that disk. This is much faster than streaming because it uses the file storage systems internal move/copy functionality

If the files are moving between two separate filesystems then we will stream the file directly from one disk to the new disk without saving the file to the laravel server first.

[freekmurze]

Thank you!