Add 'toInlineResponse' to Media

[mbardelmeijer]

Follow-up of #1358

[freekmurze]

Thanks! Could you add a test for this and also update the docs?

[mbardelmeijer]

Added!

[rcerljenko]

@mbardelmeijer @freekmurze would be great if you can optionally pass a conversion name to these functions. eg:

return $media->toResponse($request, 'thumb');

and how about responsive images?

[freekmurze]

would be great if you can optionally pass a conversion name to these function

Good idea!, could you take care of this @mbardelmeijer

Responsive images are out of scope for now.

[mbardelmeijer]

@freekmurze @rcerljenko I've checked if it would be possible to add conversion support to these methods, but ran into that the stream method from the Filesystem doesn't support passing a conversion name.

We can get the file via the default methods, but then we don't have the memory optimized stream function to use.

We can add a 'getConversionStream' method for instance in the Filesystem, and a conversionStream to the Media object, but I do think this would grow the scope of the PR too much. Thoughts?

[rcerljenko]

@mbardelmeijer yes it adds more work.. let @freekmurze decides

[freekmurze]

Let's keep it simple for now.

Thanks @mbardelmeijer