Upgrade to v8 #1728
Merged
Upgrade to v8 #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added progress bar for clear command * formating * Remove \n from done message * Typehint the parameter. * formating
* wip * wip
AlexVanderbist
requested changes
Mar 9, 2020
There was a problem hiding this comment.
Heavy PR but great update 👍
Couple of nitpicks added in review & a couple notes right here:
-
media-library:*commands namechange missing in upgrading.md -
media-library.phpconfig file namechange missing in upgrading.md - Check composer dev dependencies (some are dependencies, others should be suggests)
|
Great code review, thanks @AlexVanderbist 👍 |
* Use native file copy If a file and the media destination are on the same disk, use native copy operation instead of streaming * Fix disk
ipontt
added a commit
to ipontt/laravel-medialibrary
that referenced
this pull request
Jun 19, 2021
This PR adds back the `down()` method that was removed by [PR spatie#1728](spatie#1728) in [commit 1f4dabf](spatie@1f4dabf#diff-821c7e5cbbc1e3d5945cc51d2ca159de2fdd08d743517383188e286f86dd154b).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.