added heic support

spatie · Sep 30, 2023 · 46dcd5a · 46dcd5a
1 parent e5251db
commit 46dcd5a
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 0 deletions.
diff --git a/src/Conversions/ImageGenerators/Image.php b/src/Conversions/ImageGenerators/Image.php
@@ -22,6 +22,8 @@ public function supportedExtensions(): Collection
         $extensions = ['png', 'jpg', 'jpeg', 'gif', 'webp', 'avif'];
         if (config('media-library.image_driver') === 'imagick') {
             $extensions[] = 'tiff';
+            $extensions[] = 'heic';
+            $extensions[] = 'heif';
         }
 
         return collect($extensions);
@@ -32,6 +34,8 @@ public function supportedMimeTypes(): Collection
         $mimeTypes = ['image/jpeg', 'image/gif', 'image/png', 'image/webp', 'image/avif'];
         if (config('media-library.image_driver') === 'imagick') {
             $mimeTypes[] = 'image/tiff';
+            $mimeTypes[] = 'image/heic';
+            $mimeTypes[] = 'image/heif';
         }
 
         return collect($mimeTypes);

diff --git a/tests/Conversions/ImageGenerators/ImageTest.php b/tests/Conversions/ImageGenerators/ImageTest.php
@@ -33,3 +33,22 @@ function () {
         expect($media->getPath())->toEqual($imageFile);
     }
 )->skip(! extension_loaded('imagick'), 'The imagick extension is not available.');
+
+it(
+    'can convert a heic image',
+    function () {
+        //heic format requires imagick
+        config(['media-library.image_driver' => 'imagick']);
+
+        $imageGenerator = new Image();
+
+        $media = $this->testModelWithoutMediaConversions->addMedia($this->getTestHeic())->toMediaCollection();
+
+        expect($imageGenerator->canConvert($media))->toBeTrue();
+
+        $imageFile = $imageGenerator->convert($media->getPath());
+
+        expect(mime_content_type($imageFile))->toEqual('image/heic');
+        expect($media->getPath())->toEqual($imageFile);
+    }
+)->skip(! extension_loaded('imagick'), 'The imagick extension is not available.');
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -243,6 +243,11 @@ public function getTestAvif(): string
         return $this->getTestFilesDirectory('test.avif');
     }
 
+    public function getTestHeic(): string
+    {
+        return $this->getTestFilesDirectory('test.heic');
+    }
+
     public function getTestMp4(): string
     {
         return $this->getTestFilesDirectory('test.mp4');

diff --git a/tests/TestSupport/testfiles/test.heic b/tests/TestSupport/testfiles/test.heic