Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default remote_sites_path to base_path() #7

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Change default remote_sites_path to base_path() #7

merged 1 commit into from
Jun 21, 2021

Conversation

lakuapik
Copy link
Contributor

As issued here https://github.com/facade/ignition/issues/314, many people have problem with remote_sites_path not working as expected.

I think its the local_sites_path that they were talking about, one problem i found is when we set remote_sites_path to directory other than laravel base_path, the local_sites_path just wont work. the url fallback-ted to default and local_sites_path never used.

One simple solution i found was changing the remote_sites_path to laravel base_path instead of empty string '' or null, then only set the local_sites_path.

I have tested on facade/ignition, but not tested yet with spatie/laravel-ignition since i cannot install from packagist:

image


note: #CMIIW, i still dont really know what happened under the hood 😃

@freekmurze freekmurze merged commit bb45bc8 into spatie:main Jun 21, 2021
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants