Change default remote_sites_path to base_path() #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As issued here https://github.com/facade/ignition/issues/314, many people have problem with
remote_sites_path
not working as expected.I think its the
local_sites_path
that they were talking about, one problem i found is when we setremote_sites_path
to directory other than laravelbase_path
, thelocal_sites_path
just wont work. the url fallback-ted to default andlocal_sites_path
never used.One simple solution i found was changing the
remote_sites_path
to laravelbase_path
instead of empty string''
ornull
, then only set thelocal_sites_path
.I have tested on
facade/ignition
, but not tested yet withspatie/laravel-ignition
since i cannot install from packagist:note: #CMIIW, i still dont really know what happened under the hood 😃