Pagination links being removed when transforming DataCollection

[bmw27]

I was messing around with this package and noticed it removes the links collection provided by Laravel's LengthAwarePaginator when transforming a DataCollection.

laravel-data/src/Transformers/DataCollectionTransformer.php

Lines 68 to 77 in b1c8975

	protected function wrapPaginatedArray(array $paginated): array
	{
	return [
	'data' => $paginated['data'],
	'meta' => Arr::except($paginated, [
	'data',
	'links',
	]),
	];
	}

Is there a way to override this behavior? I'm new to using data objects and API resources in general, so sorry if this is a dumb question 😅.

[rubenvanassche]

Hi @bmw27,

Good point! This should be fixed in the release later today!

[bmw27]

Awesome! Thanks for all the work you and Spatie do.

[didac-adria]

Hey!

I would like to re-open this topic. I have noticed that the links collection is organized differently than how Laravel does it currently.

Laravel returns Links full info inside metadata and a short version at the same level of metadata and data:

But Laravel-data package returns only full version at the same level of metadata and data:

This is a problem because our pagination logic on the frontend is re-used over all endpoints. In most of them, we use pagination as per Laravel's structure. But if we return a collection with the laravel-data package, we need to implement different logic for pagination in the frontend.

I think it's interesting to use the same structure as laravel for pagination data. What do you think @rubenvanassche ?

Thanks in advance!

[rubenvanassche]

Yeah you're right, you can always PR such feature!

[didac-adria]

yeah, we will have to investigate exactly how this works. We will have a look if we can. Thanks!
@albert-mestres

[davidkvasnovsky]

Has this already been implemented, or are you open to PR? @rubenvanassche @didac-adria

I think it would be nice if we could unify pagination behavior between native Laravel and the Laravel-data package.

[didac-adria]

Hey!
I didn't find the time to work on this. Unless it has been implemented in any package updates since then, I guess they will welcome your PR.