Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better command path handling #74

Merged
merged 1 commit into from
Feb 25, 2016

Conversation

xeno010
Copy link

@xeno010 xeno010 commented Feb 24, 2016

Current situation:

// In Config
'dump_command_path' => '' -> Works
'dump_command_path' => 'path_without_slash' -> Fails **
'dump_command_path' => 'path_with_/' -> Works

** sprintf('%smysqldump ...', $this->getDumpCommandPath());
=> path_without_slashmysqldump

My PR fix that:

'dump_command_path' => '' -> Works
'dump_command_path' => 'path_without_slash' -> Works **
'dump_command_path' => 'path_with_/' -> Works

** sprintf('%smysqldump ...', $this->getDumpCommandPath());
=> path_without_slash/mysqldump

freekmurze added a commit that referenced this pull request Feb 25, 2016
@freekmurze freekmurze merged commit 78959f5 into spatie:master Feb 25, 2016
@freekmurze
Copy link
Member

Thanks!

@freekmurze
Copy link
Member

This code of this PR is included in version 2.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants