Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list command #73

Merged
merged 1 commit into from
Feb 25, 2016
Merged

Add list command #73

merged 1 commit into from
Feb 25, 2016

Conversation

xeno010
Copy link

@xeno010 xeno010 commented Feb 24, 2016

Add new list command: php artisan backup:list

List all backups

unbenannt

@freekmurze
Copy link
Member

Thanks for your contribution. Awesome feature. I'll review it in detail in the coming days.

@freekmurze
Copy link
Member

Some remarks on the output:

  • the "create at" column should be renamed "Created at"
  • it think it's better to output just one table for all backups. There should be a column named "Filesystem" that list the name of the filesystem the backup is saved on.
  • the "Expired in" column should be replace by and "Age" column that shows the age in days.

In your code you use several abbreviations like $col and $v. Please use full variable names, the are easier to read.

Could you make these changes? Then I'll pull.

@xeno010 xeno010 force-pushed the list-command branch 2 times, most recently from 51b4bba to 4ecfe66 Compare February 25, 2016 07:52
@xeno010
Copy link
Author

xeno010 commented Feb 25, 2016

Thank you very much for your feedback.

I have done all the points.

Here a new screenshot
unbenannt2

freekmurze added a commit that referenced this pull request Feb 25, 2016
@freekmurze freekmurze merged commit 1dc8c61 into spatie:master Feb 25, 2016
@freekmurze
Copy link
Member

Thanks!

@freekmurze
Copy link
Member

This code of this PR is included in version 2.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants