Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when no socket is defined #26

Merged
merged 1 commit into from
Apr 15, 2015
Merged

Fix issue when no socket is defined #26

merged 1 commit into from
Apr 15, 2015

Conversation

foxted
Copy link

@foxted foxted commented Apr 15, 2015

A client of mine had some issues with this package recently:

when exporting the database only without any socket defined, the exported file had only one table.

@MatthiasDeWinter
Copy link

Hi,

Good spot!

I have tried your changes and it works like a charm, but when I run the tests they fail, even though Travis passes.

Can you try running the tests on your end? ( $ vendor/bin/phpunit)

@foxted
Copy link
Author

foxted commented Apr 15, 2015

That's odd, the tests pass on my end as well!

freekmurze added a commit that referenced this pull request Apr 15, 2015
Fix issue when no socket is defined
@freekmurze freekmurze merged commit 2182a72 into spatie:master Apr 15, 2015
@freekmurze
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants