Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord Notifications - Add limits in embed structures in discord notifications messages #1864

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

mho22
Copy link
Contributor

@mho22 mho22 commented Dec 31, 2024

Based on issue #1819.

Reopened pull request from #1834

@Nielsvanpach This is an initial pull request version. I may need further guidance to ensure it is ready for merging.

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you add a test to verify if this works?

src/Notifications/Channels/Discord/DiscordMessage.php Outdated Show resolved Hide resolved
@mho22
Copy link
Contributor Author

mho22 commented Jan 3, 2025

@Nielsvanpach I added a DiscordMessageTest.php in tests/Notifications/Channels/Discord directory to match the modifications I made into the DiscordMessage.php file regarding embed limits. Let me know if something is missing.

@Nielsvanpach Nielsvanpach merged commit 3d91654 into spatie:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants