New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use defined config #1726

Closed

xolf wants to merge 1 commit into spatie:main from xolf:patch-1

xolf commented Oct 26, 2023

I added spatie/laravel-backup to my project and was curious why it wasn't using my default database and filesystem for the backup.

With replacing the hardcoded settings for the database and filesystem, the packe might be instantly used out of the box.


          Use pre-configured settings

722fb59

xolf changed the title ~~Use already defined config~~ Use defined config

Member

freekmurze commented Oct 27, 2023

I think it's a good change, but right now this might change behaviour for some users.

I'll take a look again when creating the next major version.

freekmurze added the revisit for next major version label

freekmurze closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revisit for next major version