Possibility of adding timestamp to database dump filename #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a test for this? |
|
I'll try :) Do you mean creating a new test with this option set? |
boryn
force-pushed
the
db-dump-file-timestamp
branch
from
d544444 to
ffb41ed
Compare
|
Ok, @freekmurze I have just added the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment, after unzipping several dumps, the db filename always is the same - which makes it difficult to do any comparisons between them, and we are unaware when they have been taken.
With this PR, you can choose a timestamp format (through the
'database_dump_file_timestamp_format'config option), which will be inserted into the db dump filename and now it's clear when it was taken, eg.:mysql-PROJECT-2023-10-02-07-00-00.sql