Made username parameter nullable

spatie · Jul 14, 2024 · 8f1f08e · 8f1f08e
1 parent fff9b03
commit 8f1f08e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/config/backup.php b/config/backup.php
@@ -236,14 +236,12 @@
             'webhook_url' => '',
 
             /*
-             * If this is an empty string, the name field on the webhook will be used.
+             * If this is an empty string, the name field will be 'Laravel Backup'.
+             * If this is set to null, the name field on the webhook will be used.
              */
             'username' => '',
 
-            /*
-             * If this is an empty string, the avatar on the webhook will be used.
-             */
-            'avatar_url' => '',
+            'avatar_url' => null,
         ],
     ],
 

diff --git a/src/Notifications/Channels/Discord/DiscordMessage.php b/src/Notifications/Channels/Discord/DiscordMessage.php
@@ -10,7 +10,7 @@ class DiscordMessage
     public const COLOR_WARNING = 'fD6a02';
     public const COLOR_ERROR = 'e32929';
 
-    protected string $username = 'Laravel Backup';
+    protected ?string $username = null;
 
     protected ?string $avatarUrl = null;
 
@@ -31,7 +31,7 @@ class DiscordMessage
     public function from(?string $username = null, ?string $avatarUrl = null): self
     {
         if (! is_null($username)) {
-            $this->username = $username;
+            $this->username = empty($username) ? 'Laravel Backup' : $username;
         }
 
         if (! is_null($avatarUrl)) {