Fix cast to array bug

[kapersoft]

Fixes #680; test for the issue is included.

Let me know if you have any questions or remarks.

[Gummibeer]

seems good to me - will check it in depth tomorrow

[Gummibeer]

We still support L6 - so we also need Orchestra 4.

[Gummibeer]

The json cast is the same. And does this happen with collections/objects too? 🤔

[Gummibeer]

At the end I'm still not sure what we are doing wrong? 🤔
Isn't this something to get fixed in the core? I mean in theory this should also happen if you call getAttribute() your own?

[ron-florax]

If this helps, I initially thought it was an issue in the framework, but it doesn't seem to be: laravel/framework#31790

[canvural]

We also had this issue in our projects. I did some digging. I think I found something. I'm not sure.

Here it's calling getOriginal method. getOriginal method returns all the attributes, but also casts them.
So later when logChanges is working, when it calls $model->getAttribute($attribute); attribute value is already casted to array, so it throws the error.

I'm not sure this is the cause, but maybe you can investigate more.

[SudoGetBeer]

@canvural Interesting.

Maybe it is this: https://laravel.com/docs/7.x/upgrade#factory-types

The $model->getOriginal() method will now respect any casts defined on the model. Previously, this method returned the uncast, raw attributes. If you would like to continue retrieving the raw, uncast values, you may use the getRawOriginal method instead.

[canvural]

Yeah, that looks like the reason.

So, maybe this issue can be solved by using getRawOriginal (Edit: This method is added in Laravel 7. So it won't work in earlier versions)

[Gummibeer]

Thanks @kapersoft for your work here! 🎉 I was able to use everything and have extended your PR/branch.
I will close this PR in favor of #688 .

[Gummibeer]

released: https://github.com/spatie/laravel-activitylog/releases/tag/3.11.2