-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add laravel 11 support #1276
Conversation
Adds PHP 8 and Laravel 11 to testing matrix and updates illuminate dependencies BREAKING CHANGE: Drops support for PHP 8.0 and Laravel 8
This is required to be compatible with the rehashing password feature here laravel/framework#48665
+1 |
Sorry Gabriel, but PRs are handled when they are handled. Instead of reviewing the PR I now have to spend my time with this comment to educate you how to behave. Yes, this PR is open since 12d which was exactly the day after Laracon EU - probably even the reason for the PR. 🤷♂️ Yes, you want to test L11, be prepared and are enthusiastic - I get that. But that's open source, we are all doing it in our free time, we all have a real life and real jobs and I'm also not the only maintainer. Ideas for the future, instead of just tagging someone or commenting 2 characters.
|
Why was the minimum PHP version increased? I don't see the need for that BC change. |
@Gummibeer sorry for the pings I get it if you want to wait full stable release before merging this PR. Only edge case I could find (not sure if is a breaking change) is if someone change db driver to mariadb, because "batch_uuid" would be already created with char(36) and now it will use native uuid type as merged here: |
Since I'm prepping a project of my own for L11 in which I use this package, I'll take care of this now 👍 Contrary to popular belief, dropping PHP / Laravel version is not a breaking change as composer will not pull in the new version in projects that don't support it. Take this opportunity to thank @Gummibeer for all work on this repo 👍 |
This PR adds PHP 8.3 and Laravel 11 to testing matrix and updates illuminate dependencies.
BREAKING CHANGE: Drops support for PHP 8.0 and Laravel 8