-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Windows retrying as administrator to update PHP ini #4
Conversation
This seems to be related to our issue with having two composer autoloaders via https://github.com/humbug/php-scoper/blob/master/docs/limitations.md#composer-autoloader |
Ooof, this is going to be super tricky to get up and running with |
Maybe we could split |
Bah! It was box's requirements checker. It was storing it's composer autoload that it generates inside of it's vendor directory into the generated phar itself. Took a while 😅 We're all green @freekmurze! |
Very cool, thanks for having gone the extra mile here. 👍 I usually don't care too much about Windows users 😬 |
Happy to help! And haha we can't forget about them Freek! 😄 |
This PR implements the Windows retrying as an administrator functionality as seen in the video below:
Let me know if you'd like any adjustments or changes to anything, thanks! 🙏
Screen.Recording.2022-02-28.at.9.30.27.AM.mov