Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Windows retrying as administrator to update PHP ini #4

Merged
merged 6 commits into from
Mar 1, 2022

Conversation

stevebauman
Copy link
Collaborator

This PR implements the Windows retrying as an administrator functionality as seen in the video below:

Let me know if you'd like any adjustments or changes to anything, thanks! 🙏

Screen.Recording.2022-02-28.at.9.30.27.AM.mov

@stevebauman
Copy link
Collaborator Author

This seems to be related to our issue with having two composer autoloaders via ray()and dd() phars:

https://github.com/humbug/php-scoper/blob/master/docs/limitations.md#composer-autoloader

humbug/php-scoper#298 (comment)

@stevebauman
Copy link
Collaborator Author

Ooof, this is going to be super tricky to get up and running with dd() and ray() being two different phars. We'll have to somehow hijack scopers autoload generation, or generate the phars in two separate processes so the composer autoloaders have different class names.

@freekmurze
Copy link
Member

Ooof, this is going to be super tricky to get up and running with dd() and ray() being two different phars. We'll have to somehow hijack scopers autoload generation, or generate the phars in two separate processes so the composer autoloaders have different class names.

Maybe we could split build into two commands (build-ray and build-dump) and use two separate workflows.
Would that solve the issue?

@stevebauman
Copy link
Collaborator Author

stevebauman commented Mar 1, 2022

Bah! It was box's requirements checker. It was storing it's composer autoload that it generates inside of it's vendor directory into the generated phar itself.

Took a while 😅

We're all green @freekmurze!

@freekmurze
Copy link
Member

Very cool, thanks for having gone the extra mile here. 👍

I usually don't care too much about Windows users 😬

@freekmurze freekmurze merged commit a3aa5e6 into main Mar 1, 2022
@freekmurze freekmurze deleted the feature-retry-as-windows-admin branch March 1, 2022 15:47
@stevebauman
Copy link
Collaborator Author

Happy to help! And haha we can't forget about them Freek! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants