Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: reduce dependency tree #89

Merged

Conversation

michelmegens
Copy link
Contributor

@michelmegens michelmegens commented Jul 7, 2020

This package can only be used in laravel-framework projects, due to the composer dependency on said framework. The library itself only depends on eloquent (i.e. various illuminate packages). This package can therefore be used in lumen-framework projects as well, by depending on the illuminate packages only.

Reduce the dependency tree to some illuminate packages in order to support
the lumen-framework package.

Signed-off-by: Michel Megens <[email protected]>
@michelmegens michelmegens marked this pull request as ready for review July 7, 2020 15:03
@freekmurze freekmurze merged commit 6f80ed8 into spatie:master Jul 8, 2020
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants