Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boundary #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

HuangLiPang
Copy link

adding boundary option
boundary

@spatialsparks
Copy link
Owner

Hi HuangLiPang, sorry for the late reply and thx for the pull request. Your screenshot looks a bit weird at the edges, whats happening there? Or could you quickly show a side-by-side comparison of with boundary and without boundary? I am a bit sceptical about that blue ring on the bottom left where yellow transitions right to blue...
Best regards

@HuangLiPang
Copy link
Author

Hi @JoranBeaufort !
Thank you for your comment.
I have a demo version which can see the interpolation value.
You can check the demo here.
I also fixed a half-cell length offset here.

@spatialsparks
Copy link
Owner

spatialsparks commented Jul 17, 2019

Hi @HuangLiPang
Thanks for the links, unfortunately the link is not working at the moment, Ill check back later. And The half cell offset was actually on purpose: the reasoning is that I wanted the data points which have the value of a cell to be in the middle (the centroid) of a cell. If you remove the half cell offset, then the "point" in your cell which actually has the interpolated value will be a corner of the cell which I found to be less intuitive.
Cheers

Edit: Try to replace "https" with "http" in https://cdn.leafletjs.com/leaflet/v1.0.0-beta.2/leaflet.js for the time being

@HuangLiPang
Copy link
Author

I used incognito mode. The link works. Maybe you should hard fresh the browser since the demo is used gh-pages.
I got the point of the offset.

@spatialsparks
Copy link
Owner

Hm, I tried in incognito but get the same errors:
huanglipang_error

@HuangLiPang
Copy link
Author

HuangLiPang commented Jul 17, 2019

I got the same error when I used http, so I changed it to https.
I changed it to http now. Please try the link again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants