This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
UTY-2661: Improve snapshot api #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2661 |
improbable-prow-robot
added
do-not-merge/work-in-progress
improbable-prow-robot
added
A: core
BryanJY-Wong
commented
Sep 8, 2020
workers/unity/Packages/io.improbable.gdk.core/Utility/Snapshot.cs
Outdated
Show resolved
Hide resolved
BryanJY-Wong
commented
Sep 8, 2020
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
jamiebrynes7
reviewed
Sep 8, 2020
There was a problem hiding this comment.
While you're here, can you cherry pick the Snapshot changes from https://github.com/spatialos/gdk-for-unity/pull/1477/files#diff-6cbb5e5c9ae6005cf38f5951cabcfbecR89 which fixes a memory leak (assuming you dispose the Snapshot).
workers/unity/Packages/io.improbable.gdk.core/Utility/Snapshot.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Utility/Snapshot.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Tests/EditmodeTests/Correctness/Utility/SnapshotTests.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Utility/Snapshot.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Utility/Snapshot.cs
Outdated
Show resolved
Hide resolved
jamiebrynes7
reviewed
Sep 8, 2020
workers/unity/Assets/Tests/EditmodeTests/Correctness/Utility/SnapshotTests.cs
Outdated
Show resolved
Hide resolved
…napshotTests.cs Co-authored-by: Jamie Brynes <[email protected]>
jamiebrynes7
approved these changes
Sep 8, 2020
CHANGELOG.md
Outdated
Comment on lines
10
to
11
| - Added new features to the `Snapshot` class [#1479](https://github.com/spatialos/gdk-for-unity/pull/1479) | ||
| - Adding duplicate entity ID now throws an exception |
There was a problem hiding this comment.
Suggested change
| - Added new features to the `Snapshot` class [#1479](https://github.com/spatialos/gdk-for-unity/pull/1479) | |
| - Adding duplicate entity ID now throws an exception | |
| - Adding an entity to the `Snapshot` class with a duplicate entity ID now throws an exception. [#1479](https://github.com/spatialos/gdk-for-unity/pull/1479) |
improbable-prow-robot
removed
the
size/M
improbable-prow-robot
added
the
size/L
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
Snapshotclass:EntityIdis validEntityIdTests
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.