This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Default SceneConverter implementation #1477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
improbable-prow-robot
added
A: core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a default implementation for Scene -> Snapshot using the interfaces defined in #1466. There were also a few related changes to make this more ergonomic/correct:
Snapshotnow implementsIDisposableas we need to dispose of the serialized schema data once we write out a snapshot.Snapshotnow auto-adds thePersistencecomponent to entities. I.e. -snapshot.Add(entityTemplate);is pretty clear you do want the entity to be persistent!Tests
Documentation