Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Unity 2020.1 Upgrade #1459

Merged
merged 9 commits into from
Aug 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .buildkite/premerge.steps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ windows: &windows
- "environment=production"
- "permission_set=builder"
- "platform=windows"
- "queue=${WINDOWS_BUILDER_QUEUE:-v4-20-07-30-165418-bk13785-82b83865-d}"
- "queue=${WINDOWS_BUILDER_QUEUE:-v4-20-08-13-090826-bk14267-5f831930-d}"
- "scaler_version=2"
- "minimum_instances=1"
- "agent_count=1"
Expand All @@ -33,8 +33,8 @@ windows: &windows
# Workaround for flaky Git clones, likely due to - https://github.com/PowerShell/Win32-OpenSSH/issues/1322
- exit_status: 128
limit: 3
env: &windows-env
ACCELERATOR_ENDPOINT: "unity-accelerator.production-intinf-eu1.i8e.io"
# env: &windows-env
# ACCELERATOR_ENDPOINT: "unity-accelerator.production-intinf-eu1.i8e.io"

linux: &linux
agents:
Expand Down Expand Up @@ -147,7 +147,7 @@ steps:
- logs/**/*
- workers/unity/build/worker/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "MobileClient"
BUILD_ENVIRONMENT: "local"
BUILD_TARGET_FILTER: "android"
Expand All @@ -159,7 +159,7 @@ steps:
artifact_paths:
- logs/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "UnityClient"
BUILD_ENVIRONMENT: "cloud"
SCRIPTING_BACKEND: "mono"
Expand All @@ -170,7 +170,7 @@ steps:
artifact_paths:
- logs/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "UnityClient"
BUILD_ENVIRONMENT: "local"
SCRIPTING_BACKEND: "il2cpp"
Expand All @@ -181,7 +181,7 @@ steps:
artifact_paths:
- logs/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "UnityGameLogic"
BUILD_ENVIRONMENT: "cloud"
SCRIPTING_BACKEND: "mono"
Expand Down
14 changes: 7 additions & 7 deletions .buildkite/release-qa.steps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ windows: &windows
- "environment=production"
- "permission_set=builder"
- "platform=windows"
- "queue=${WINDOWS_BUILDER_QUEUE:-v4-20-07-30-165418-bk13785-82b83865-d}"
- "queue=${WINDOWS_BUILDER_QUEUE:-v4-20-08-13-090826-bk14267-5f831930-d}"
- "scaler_version=2"
- "minimum_instances=1"
- "agent_count=1"
Expand All @@ -33,8 +33,8 @@ windows: &windows
# Workaround for flaky Git clones, likely due to - https://github.com/PowerShell/Win32-OpenSSH/issues/1322
- exit_status: 128
limit: 3
env: &windows-env
ACCELERATOR_ENDPOINT: "unity-accelerator.production-intinf-eu1.i8e.io"
# env: &windows-env
# ACCELERATOR_ENDPOINT: "unity-accelerator.production-intinf-eu1.i8e.io"

# NOTE: step labels turn into commit-status names like {org}/{repo}/{pipeline}/{step-label}, lower-case and hyphenated.
# These are then relied on to have stable names by other things, so once named, please beware renaming has consequences.
Expand All @@ -47,7 +47,7 @@ steps:
- logs/**/*
- build/assembly/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "MobileClient"
BUILD_ENVIRONMENT: "cloud"
BUILD_TARGET_FILTER: "android"
Expand All @@ -60,7 +60,7 @@ steps:
- logs/**/*
- build/assembly/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "MobileClient"
BUILD_ENVIRONMENT: "cloud"
BUILD_TARGET_FILTER: "ios"
Expand All @@ -73,7 +73,7 @@ steps:
- logs/**/*
- build/assembly/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "UnityClient"
BUILD_ENVIRONMENT: "cloud"
SCRIPTING_BACKEND: "mono"
Expand All @@ -85,7 +85,7 @@ steps:
- logs/**/*
- build/assembly/**/*
env:
<<: *windows-env
# <<: *windows-env
WORKER_TYPE: "UnityGameLogic"
BUILD_ENVIRONMENT: "cloud"
SCRIPTING_BACKEND: "mono"
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Breaking Changes

- The minimum supported version of Unity is now 2020.1. [#1459](https://github.com/spatialos/gdk-for-unity/pull/1459)

### Added

- Added `MeansImplicitUse` attribute to `RequireAttribute` to reduce warnings in Rider IDE. [#1462](https://github.com/spatialos/gdk-for-unity/pull/1462)
Expand Down
6 changes: 6 additions & 0 deletions UPGRADE_GUIDE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Upgrade Guide

## From `0.3.10` to `0.4.0`

### Unity 2020.1

In order to use the GDK for Unity `0.4.0`, you will need to upgrade your project to Unity 2020.1. We test against 2020.1.2f1, but any `2020.1.x` version _should_ work.

## From `0.3.9` to `0.3.10`

### AuthorityLossImminent support removed
Expand Down
1 change: 1 addition & 0 deletions workers/unity/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
/ProjectSettings/UnityConnectSettings.asset
/*.csproj
/*.sln
/Packages/packages-lock.json
jamiebrynes7 marked this conversation as resolved.
Show resolved Hide resolved

# Build artifacts
/build/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Linq;
using Improbable.Gdk.Core;
using Unity.Entities;
using UnityEditor;
Expand Down Expand Up @@ -30,7 +31,7 @@ public EntityList()
listView = this.Q<ListView>();
listView.makeItem = () => new Label();
listView.bindItem = BindItem;
listView.onSelectionChanged += OnSelectionChanged;
listView.onSelectionChange += OnSelectionChanged;
listView.itemsSource = entities.FilteredData;

var searchField = this.Q<ToolbarSearchField>();
Expand Down Expand Up @@ -83,16 +84,16 @@ private void BindItem(VisualElement element, int index)
label.text = entity.ToString();
}

private void OnSelectionChanged(List<object> selections)
private void OnSelectionChanged(IEnumerable<object> selections)
{
if (selections.Count != 1)
if (selections.Count() != 1)
{
throw new InvalidOperationException("Unexpectedly selected more than one entity.");
}

if (!(selections[0] is EntityData entityData))
if (!(selections.First() is EntityData entityData))
{
throw new InvalidOperationException($"Unexpected type for selection: {selections[0].GetType()}");
throw new InvalidOperationException($"Unexpected type for selection: {selections.First().GetType()}");
}

if (!selectedEntity.HasValue || selectedEntity.Value != entityData)
Expand Down
4 changes: 2 additions & 2 deletions workers/unity/Packages/manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"dependencies": {
"com.unity.ide.rider": "1.2.1",
"com.unity.ide.visualstudio": "2.0.1",
"com.unity.ide.rider": "2.0.7",
"com.unity.ide.visualstudio": "2.0.2",
"com.unity.quicksearch": "2.0.0",
"com.unity.testtools.codecoverage": "0.2.3-preview",
"com.unity.ugui": "1.0.0",
Expand Down
18 changes: 18 additions & 0 deletions workers/unity/ProjectSettings/PackageManagerSettings.asset
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
%YAML 1.1
%TAG !u! tag:unity3d.com,2011:
--- !u!114 &1
MonoBehaviour:
m_ObjectHideFlags: 61
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 13964, guid: 0000000000000000e000000000000000, type: 0}
m_Name:
m_EditorClassIdentifier:
m_EnablePreviewPackages: 1
m_EnablePackageDependencies: 1
m_AdvancedSettingsExpanded: 1
oneTimeWarningShown: 1
38 changes: 19 additions & 19 deletions workers/unity/ProjectSettings/ProjectSettings.asset
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ PlayerSettings:
m_StereoRenderingPath: 0
m_ActiveColorSpace: 0
m_MTRendering: 1
mipStripping: 0
numberOfMipsStripped: 0
m_StackTraceTypes: 010000000100000001000000010000000100000001000000
iosShowActivityIndicatorOnLoading: -1
androidShowActivityIndicatorOnLoading: -1
Expand Down Expand Up @@ -111,6 +113,10 @@ PlayerSettings:
switchNVNShaderPoolsGranularity: 33554432
switchNVNDefaultPoolsGranularity: 16777216
switchNVNOtherPoolsGranularity: 16777216
switchNVNMaxPublicTextureIDCount: 0
switchNVNMaxPublicSamplerIDCount: 0
stadiaPresentMode: 0
stadiaTargetFramerate: 0
vulkanNumSwapchainBuffers: 3
vulkanEnableSetSRGBWrite: 0
m_SupportedAspectRatios:
Expand Down Expand Up @@ -184,32 +190,16 @@ PlayerSettings:
StripUnusedMeshComponents: 1
VertexChannelCompressionMask: 4054
iPhoneSdkVersion: 988
iOSTargetOSVersionString: 10.0
iOSTargetOSVersionString: 11.0
tvOSSdkVersion: 0
tvOSRequireExtendedGameController: 0
tvOSTargetOSVersionString: 10.0
tvOSTargetOSVersionString: 11.0
uIPrerenderedIcon: 0
uIRequiresPersistentWiFi: 0
uIRequiresFullScreen: 1
uIStatusBarHidden: 1
uIExitOnSuspend: 0
uIStatusBarStyle: 0
iPhoneSplashScreen: {fileID: 0}
iPhoneHighResSplashScreen: {fileID: 0}
iPhoneTallHighResSplashScreen: {fileID: 0}
iPhone47inSplashScreen: {fileID: 0}
iPhone55inPortraitSplashScreen: {fileID: 0}
iPhone55inLandscapeSplashScreen: {fileID: 0}
iPhone58inPortraitSplashScreen: {fileID: 0}
iPhone58inLandscapeSplashScreen: {fileID: 0}
iPadPortraitSplashScreen: {fileID: 0}
iPadHighResPortraitSplashScreen: {fileID: 0}
iPadLandscapeSplashScreen: {fileID: 0}
iPadHighResLandscapeSplashScreen: {fileID: 0}
iPhone65inPortraitSplashScreen: {fileID: 0}
iPhone65inLandscapeSplashScreen: {fileID: 0}
iPhone61inPortraitSplashScreen: {fileID: 0}
iPhone61inLandscapeSplashScreen: {fileID: 0}
appleTVSplashScreen: {fileID: 0}
appleTVSplashScreen2x: {fileID: 0}
tvOSSmallIconLayers: []
Expand Down Expand Up @@ -275,6 +265,9 @@ PlayerSettings:
height: 180
banner: {fileID: 0}
androidGamepadSupportLevel: 0
AndroidMinifyWithR8: 0
AndroidMinifyRelease: 0
AndroidMinifyDebug: 0
AndroidValidateAppBundleSize: 1
AndroidAppBundleSizeToValidate: 150
m_BuildTargetIcons: []
Expand Down Expand Up @@ -433,12 +426,14 @@ PlayerSettings:
cameraUsageDescription:
locationUsageDescription:
microphoneUsageDescription:
switchNMETAOverride:
switchNetLibKey:
switchSocketMemoryPoolSize: 6144
switchSocketAllocatorPoolSize: 128
switchSocketConcurrencyLimit: 14
switchScreenResolutionBehavior: 2
switchUseCPUProfiler: 0
switchUseGOLDLinker: 0
switchApplicationID: 0x01004b9000490000
switchNSODependencies:
switchTitleNames_0:
Expand Down Expand Up @@ -614,6 +609,7 @@ PlayerSettings:
ps4UseResolutionFallback: 0
ps4ReprojectionSupport: 0
ps4UseAudio3dBackend: 0
ps4UseLowGarlicFragmentationMode: 1
ps4SocialScreenEnabled: 0
ps4ScriptOptimizationLevel: 0
ps4Audio3dVirtualSpeakerCount: 14
Expand Down Expand Up @@ -649,9 +645,10 @@ PlayerSettings:
webGLAnalyzeBuildSize: 0
webGLUseEmbeddedResources: 0
webGLCompressionFormat: 1
webGLWasmArithmeticExceptions: 0
webGLLinkerTarget: 0
webGLThreadsSupport: 0
webGLWasmStreaming: 0
webGLDecompressionFallback: 0
scriptingDefineSymbols:
1: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP
4: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP
Expand All @@ -676,6 +673,7 @@ PlayerSettings:
managedStrippingLevel: {}
incrementalIl2cppBuild: {}
allowUnsafeCode: 0
useDeterministicCompilation: 1
additionalIl2CppArgs:
scriptingRuntimeVersion: 1
gcIncremental: 0
Expand Down Expand Up @@ -737,6 +735,7 @@ PlayerSettings:
XboxOnePersistentLocalStorageSize: 0
XboxOneXTitleMemory: 8
XboxOneOverrideIdentityName:
XboxOneOverrideIdentityPublisher:
vrEditorSettings:
daydream:
daydreamIconForeground: {fileID: 0}
Expand All @@ -763,3 +762,4 @@ PlayerSettings:
enableNativePlatformBackendsForNewInputSystem: 0
disableOldInputManagerSupport: 0
legacyClampBlendShapeWeights: 1
virtualTexturingSupportEnabled: 0
4 changes: 2 additions & 2 deletions workers/unity/ProjectSettings/ProjectVersion.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
m_EditorVersion: 2019.3.7f1
m_EditorVersionWithRevision: 2019.3.7f1 (6437fd74d35d)
m_EditorVersion: 2020.1.2f1
m_EditorVersionWithRevision: 2020.1.2f1 (7b32bc54ba47)
8 changes: 8 additions & 0 deletions workers/unity/ProjectSettings/VersionControlSettings.asset
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
%YAML 1.1
%TAG !u! tag:unity3d.com,2011:
--- !u!890905787 &1
VersionControlSettings:
m_ObjectHideFlags: 0
m_Mode: Visible Meta Files
m_CollabEditorSettings:
inProgressEnabled: 1