This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Jobify serialization #1454
Merged
Jobify serialization #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
improbable-prow-robot
added
A: core
zeroZshadow
force-pushed
the
feature/jobify-serialization-test
branch
from
d81f9f1 to
1f55395
Compare
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
|
This has been tested against the FPS project, in the cloud with 200 players |
zeroZshadow
force-pushed
the
feature/jobify-serialization-test
branch
from
72e6f79 to
c5056fb
Compare
paulbalaji
approved these changes
Aug 20, 2020
...robable.gdk.core/.codegen/Source/Generators/Core/UnityComponentReplicationSystemGenerator.cs
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Worker/SerializedMessagesToSend.cs
Show resolved
Hide resolved
BryanJY-Wong
approved these changes
Aug 20, 2020
Filter on changed components to avoid scheduling jobs for unchanged chunks Don't reuse queue, dispose and re-create
Hack MessagesToSend to store pre-serialized component updates
Fixes unit tests
Add DisableAutoCreate to ReplicationSystems
zeroZshadow
force-pushed
the
feature/jobify-serialization-test
branch
from
c5056fb to
99991e1
Compare
| marker.Begin(); | ||
| if (!component.IsDataDirty()) | ||
| { | ||
| marker.End(); |
There was a problem hiding this comment.
Is there a scoped version of the marker rather than handling the various branches ourselves?
There was a problem hiding this comment.
Yes, but this can be bursted, and our version of burst does not yet support using
There was a problem hiding this comment.
Ah right, soon though 😉
workers/unity/Packages/io.improbable.gdk.core/Systems/SpatialOSSendSystem.cs
Show resolved
Hide resolved
....gdk.core/Worker/ConnectionHandlers/SpatialOSConnectionHandler/SpatialOSConnectionHandler.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Worker/SerializedMessagesToSend.cs
Show resolved
Hide resolved
Rename AddComponentUpdate to AddComponentEvent
|
Kudos, SonarCloud Quality Gate passed!
|
jamiebrynes7
approved these changes
Aug 25, 2020
jamiebrynes7
added a commit
that referenced
this pull request
Aug 27, 2020
jamiebrynes7
added a commit
that referenced
this pull request
Aug 27, 2020
jamiebrynes7
pushed a commit
that referenced
this pull request
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move serialization of components into Jobs with burst.
Tests
Documentation