Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Event Tracing API wrapper #1452

Merged
merged 61 commits into from
Aug 28, 2020
Merged

Event Tracing API wrapper #1452

merged 61 commits into from
Aug 28, 2020

Conversation

seanjparker
Copy link
Contributor

@seanjparker seanjparker commented Aug 10, 2020 •
edited
Loading

For UTY-2686

Description

Tests

How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?

  • Manual testing
    • Span
    • Event
    • Event Data
    • Event Tracer
    • Item

Documentation

How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Nothing yet

  • Changelog

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket labels Aug 10, 2020
@improbable-prow-robot improbable-prow-robot added the size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. label Aug 10, 2020
@seanjparker seanjparker marked this pull request as ready for review August 11, 2020 11:57
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2020
jamiebrynes7
jamiebrynes7 previously requested changes Aug 11, 2020
View reviewed changes
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
zeroZshadow
zeroZshadow reviewed Aug 20, 2020
View reviewed changes
workers/unity/Packages/io.improbable.worker.sdk/CEventTrace.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/CIO.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/IOStream.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/IOStream.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/IOStream.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
@seanjparker
Copy link
Contributor Author

cc @improbable-jonphillips, @tbimprob I was wondering if you could take a look at these C# wrappers for the C API, in case you had any comments/suggestions about them before creating a PR into everything.

jamiebrynes7
jamiebrynes7 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but otherwise this LGTM. Don't forget a CHANGELOG entry too!

workers/unity/Packages/io.improbable.worker.sdk/CIO.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/ParameterConversion.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Outdated Show resolved Hide resolved
workers/unity/Packages/io.improbable.worker.sdk/EventTracing.cs Show resolved Hide resolved
Sean Parker added 2 commits August 26, 2020 12:51
Make requested changes for IO, EventTracing APIs
635b5ec 
Don't drop errors silently in Span/Event ParameterConversion
Add changelog entry
a794770
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@seanjparker seanjparker merged commit 9da43ba into develop Aug 28, 2020
@improbable-prow-robot improbable-prow-robot deleted the feature/event-tracing-api-wrapper branch August 28, 2020 13:01
@seanjparker seanjparker mentioned this pull request Sep 1, 2020
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulbalaji paulbalaji paulbalaji approved these changes

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@BryanJY-Wong BryanJY-Wong BryanJY-Wong approved these changes

@austinkelmore austinkelmore Awaiting requested review from austinkelmore

@zeroZshadow zeroZshadow Awaiting requested review from zeroZshadow

Assignees
No one assigned
Labels
jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seanjparker @zeroZshadow @paulbalaji @jamiebrynes7 @BryanJY-Wong @improbable-prow-robot