This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
UTY-2508: enable command tests #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
improbable-prow-robot
added
A: build-system
improbable-prow-robot
added
A: playground
BryanJY-Wong
commented
Jul 22, 2020
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
BryanJY-Wong
changed the title
improbable-prow-robot
removed
the
jira/no-ticket
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2508 |
BryanJY-Wong
force-pushed
the
feature/enable-command-tests
branch
from
04043c6 to
56f0bc2
Compare
BryanJY-Wong
changed the title
improbable-prow-robot
added
size/XL
workers/unity/Packages/io.improbable.gdk.core/Systems/CommandSystem.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Systems/CommandSystem.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockWorld.cs
Outdated
Show resolved
Hide resolved
BryanJY-Wong
commented
Jul 23, 2020
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
paulbalaji
reviewed
Jul 23, 2020
workers/unity/Packages/io.improbable.gdk.testutils/MockWorld.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Tests/EditmodeTests/Correctness/Core/NullableResponseTests.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Tests/EditmodeTests/Correctness/Subscriptions/CommandTests.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Tests/EditmodeTests/Correctness/Subscriptions/CommandTests.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Dynamic/ComponentDatabase.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Systems/CommandSystem.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.testutils/MockCommandSender.cs
Outdated
Show resolved
Hide resolved
BryanJY-Wong
force-pushed
the
feature/enable-command-tests
branch
from
5d3f25f to
c101ce6
Compare
paulbalaji
reviewed
Jul 29, 2020
workers/unity/Assets/Tests/EditmodeTests/Correctness/Core/CommandReceivedResponseTests.cs
Outdated
Show resolved
Hide resolved
BryanJY-Wong
force-pushed
the
feature/enable-command-tests
branch
from
51cb38a to
b8a444e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
paulbalaji
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a
MockCommandSenderto inject intoCommandSystemduring construction of theMockWorld. This allows generating stub responses either singularly through a knownCommandRequestIdor generating all responses for all "sent" requests.Tests
Created example use case using the
Launchercomponent.Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Did you remember a changelog entry?
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.