This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Prevent worker builds with compiler errors in Unity Editor #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
improbable-prow-robot
added
A: build-system
added 5 commits
July 14, 2020 11:50
…alos/gdk-for-unity into feature/editor-compile-error-check
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
jamiebrynes7
previously requested changes
Jul 14, 2020
workers/unity/Packages/io.improbable.gdk.buildsystem/Util/CompilerValidator.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.buildsystem/Util/CompilerValidator.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.buildsystem/Util/CompilerValidator.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.buildsystem/WorkerBuilder.cs
Outdated
Show resolved
Hide resolved
improbable-prow-robot
added
size/S
seanjparker
dismissed
jamiebrynes7’s stale review
Outdated, as taking different approach
...mprobable.gdk.buildsystem/.codegen/Source/Generators/BuildSystem/UnityWorkerMenuGenerator.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.buildsystem/Util/BuildSupportChecker.cs
Outdated
Show resolved
Hide resolved
Inline editor compile check
improbable-prow-robot
added
size/XS
jamiebrynes7
approved these changes
Jul 20, 2020
paulbalaji
approved these changes
Jul 21, 2020
...mprobable.gdk.buildsystem/.codegen/Source/Generators/BuildSystem/UnityWorkerMenuGenerator.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UTY-2478
Description
Prevents building the workers if there are compiler errors in the editor
Tests
How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?
Tested manually that dialog appeared with script errors that prevented building without confirmation
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Added entry into Changelog