This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Port Gdk Tools Configuration to Unity Project Settings #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanjparker
requested review from
austinkelmore,
zeroZshadow,
paulbalaji and
jamiebrynes7
improbable-prow-robot
added
jira/no-ticket
workers/unity/Packages/io.improbable.gdk.deploymentlauncher/DeploymentLauncherWindow.cs
Show resolved
Hide resolved
zeroZshadow
reviewed
Jun 26, 2020
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
zeroZshadow
reviewed
Jun 26, 2020
workers/unity/Packages/io.improbable.gdk.deploymentlauncher/DeploymentLauncherWindow.cs
Outdated
Show resolved
Hide resolved
added 6 commits
June 26, 2020 17:32
jamiebrynes7
approved these changes
Jun 29, 2020
paulbalaji
approved these changes
Jun 29, 2020
Co-authored-by: Paul Balaji <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UTY-2419
Description
GdkToolsConfigurationsetting window to the Unity SettingsProviderThe settings changes now save when
Project Settingswindow is closed or switched away from the Gdk Tools Configuration page (+ Only if changes are made to the settings)Tests
How did you test these changes prior to submitting this pull request?
Manually tested that the
GdkToolsConfiguration.jsonfile represented the changes made in the Project Settings view