Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add codegen tests for name clashes #1380

Merged
merged 6 commits into from
Jun 2, 2020
Merged

Add codegen tests for name clashes #1380

merged 6 commits into from
Jun 2, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Jun 1, 2020 •
edited
Loading

Description

Replace illegal.schema with unit tests using equivalent bundles.

Tests

Ran codegen tests, they pass.

Opened test-project, no longer logs name clashing errors.

Documentation

  • internal changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket labels Jun 1, 2020
@improbable-prow-robot improbable-prow-robot added A: tooling Area: Tooling size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. labels Jun 1, 2020
@paulbalaji paulbalaji changed the title Bugfix/codegen nameclash test Add codegen tests for name clashes Jun 1, 2020
@paulbalaji paulbalaji force-pushed the bugfix/codegen-nameclash-test branch from d5ea30a to f3132b7 Compare June 1, 2020 15:41
@paulbalaji paulbalaji requested a review from jamiebrynes7 June 1, 2020 15:42
@paulbalaji paulbalaji marked this pull request as ready for review June 1, 2020 15:42
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2020
jamiebrynes7
jamiebrynes7 reviewed Jun 1, 2020
View reviewed changes
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to commit the schema that generated the bundles (even though its not going to be used in any project)?

That way if the bundle format were to change, we could re-generate these without re-writing the schema

.../io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Tests/Model/NameClashingTests.cs Show resolved Hide resolved
.../io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Tests/Model/NameClashingTests.cs Outdated Show resolved Hide resolved
paulbalaji
paulbalaji commented Jun 1, 2020
View reviewed changes
Copy link
Contributor Author

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should commit the schema I used to generate these bundles

.../io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Tests/Model/NameClashingTests.cs Outdated Show resolved Hide resolved
.../io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Tests/Model/NameClashingTests.cs Show resolved Hide resolved
.../io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Tests/Model/NameClashingTests.cs Outdated Show resolved Hide resolved
Paul Balaji added 3 commits June 1, 2020 17:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

austinkelmore
austinkelmore approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@austinkelmore austinkelmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't think I know schemas well enough to catch many edge cases.

@paulbalaji paulbalaji merged commit a69a09e into develop Jun 2, 2020
@improbable-prow-robot improbable-prow-robot deleted the bugfix/codegen-nameclash-test branch June 2, 2020 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@austinkelmore austinkelmore austinkelmore approved these changes

@zeroZshadow zeroZshadow Awaiting requested review from zeroZshadow

Assignees
No one assigned
Labels
A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XL Denotes a PR that changes 300-599 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalaji @austinkelmore @jamiebrynes7 @improbable-prow-robot