This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/XL
Denotes a PR that changes 300-599 lines, ignoring generated files.
labels
Jun 1, 2020
jamiebrynes7
force-pushed
the
feature/worker-inspector-entity-detail
branch
2 times, most recently
from
June 1, 2020 15:38
8ed3e07
to
9030b29
Compare
jamiebrynes7
force-pushed
the
feature/worker-inspector-entity-detail
branch
from
June 1, 2020 15:57
9030b29
to
930abe4
Compare
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jun 1, 2020
zeroZshadow
approved these changes
Jun 2, 2020
...io.improbable.gdk.debug/.codegen/Source/Generators/DebugExtensions/DebugAssemblyGenerator.cs
Outdated
Show resolved
Hide resolved
...obable.gdk.debug/WorkerInspector/Codegen/Improbable.Gdk.Debug.WorkerInspector.Codegen.asmdef
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.debug/WorkerInspector/EntityDetail.cs
Outdated
Show resolved
Hide resolved
paulbalaji
approved these changes
Jun 2, 2020
austinkelmore
suggested changes
Jun 2, 2020
workers/unity/Packages/io.improbable.gdk.debug/WorkerInspector/EntityDetail.cs
Show resolved
Hide resolved
austinkelmore
approved these changes
Jun 2, 2020
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A: core
Area: Core GDK
A: tooling
Area: Tooling
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/XL
Denotes a PR that changes 300-599 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from #1375, this PR adds the entity detail window to the Worker Inspector. This displays information about a given entity, in this case, the set of components & whether the worker is authoritative or not. Rendering the data for the components will follow in a later PR.
This includes some new code generated files for rendering a given component. While this isn't strictly required for this PR, when we start rendering the data, it will become invaluable.
Tests
Documentation
Documentation & changelog will follow in a PR once the window is 'feature-complete'.