Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add entity detail pane #1379

Merged
merged 9 commits into from
Jun 2, 2020
Merged

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Jun 1, 2020

Description

Following on from #1375, this PR adds the entity detail window to the Worker Inspector. This displays information about a given entity, in this case, the set of components & whether the worker is authoritative or not. Rendering the data for the components will follow in a later PR.

This includes some new code generated files for rendering a given component. While this isn't strictly required for this PR, when we start rendering the data, it will become invaluable.

image

Tests

  • Ensure that the scroll view renders correctly
  • Clicking on an entity will render its components
  • The window handles the entity being removed.
  • Swapping worlds is handled correctly.
  • Performance is acceptable.

Documentation

Documentation & changelog will follow in a PR once the window is 'feature-complete'.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. labels Jun 1, 2020
@improbable-prow-robot improbable-prow-robot added A: core Area: Core GDK A: tooling Area: Tooling labels Jun 1, 2020
@jamiebrynes7 jamiebrynes7 force-pushed the feature/worker-inspector-entity-detail branch 2 times, most recently from 8ed3e07 to 9030b29 Compare June 1, 2020 15:38
@jamiebrynes7 jamiebrynes7 force-pushed the feature/worker-inspector-entity-detail branch from 9030b29 to 930abe4 Compare June 1, 2020 15:57
@jamiebrynes7 jamiebrynes7 marked this pull request as ready for review June 1, 2020 16:15
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

2.0% 2.0% Coverage
0.0% 0.0% Duplication

@jamiebrynes7 jamiebrynes7 merged commit 2b819b4 into develop Jun 2, 2020
@improbable-prow-robot improbable-prow-robot deleted the feature/worker-inspector-entity-detail branch June 2, 2020 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XL Denotes a PR that changes 300-599 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants