Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Typed command ids #1372

Merged
merged 7 commits into from
May 22, 2020
Merged

Typed command ids #1372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58fe731
Command request ID's are now typed and split between internal and normal
zeroZshadow May 20, 2020
c5ae414
Made CommandRequestIds sortable
zeroZshadow May 21, 2020
00de3e5
Changelog + Upgrade Guide
zeroZshadow May 22, 2020
cdc1d82
Apply suggestions from code review
zeroZshadow May 22, 2020
34f2aa7
Merge branch 'develop' into feature/typed-command-ids
zeroZshadow May 22, 2020
3a880aa
Remove source file with a space at the end...
zeroZshadow May 22, 2020
fe8a59e
Making sonar happy
zeroZshadow May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- `WorkerConnector.HandleWorkerConnectionFailure` has been removed and `WorkerConnector.Connect` now throws exceptions for connection errors instead. [#1365](https://github.com/spatialos/gdk-for-unity/pull/1365)
- `WorkerConnector` no longer destroys itself in `Dispose`. [#1365](https://github.com/spatialos/gdk-for-unity/pull/1365)
- `MultiThreadedSpatialOSConnectionHandler` and `SpatialOSConnectionHandlerBuilder.SetThreadingMode` have been removed. [#1367](https://github.com/spatialos/gdk-for-unity/pull/1367)
- Command request ID's are now typed as `CommandRequestID` instead of `long`. [#1372](https://github.com/spatialos/gdk-for-unity/pull/1372)
zeroZshadow marked this conversation as resolved.
Show resolved Hide resolved

### Added

Expand Down
7 changes: 7 additions & 0 deletions UPGRADE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

## From `0.3.5` to `0.3.6`

### Command Request ID's are now typed

The return value of `CommandSystem.SendCommand` has changed from `long` to `CommandRequestID`.
A similar change has been made to all API's that take request ID's as a parameter.
zeroZshadow marked this conversation as resolved.
Show resolved Hide resolved

Anywhere you store request ids, you need to change the type from `long` to `CommandRequestId`.
zeroZshadow marked this conversation as resolved.
Show resolved Hide resolved

### Multithreaded connection removed

The `MultiThreadedSpatialOSConnectionHandler` has been removed and the method `SpatialOSConnectionHandlerBuilder.SetThreadingMode` has been removed to reflect this change.
Expand Down