Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Add convenience method to the MockConnection #1370

Merged
merged 4 commits into from
May 22, 2020

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented May 21, 2020

Description

See branch name for motivation, you can now remove components & an entity the same way you add them.

Tests

  • Updated a test to double check!

Documentation

  • Changelog?

@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label May 21, 2020
@improbable-prow-robot improbable-prow-robot added A: core Area: Core GDK size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels May 21, 2020
Copy link
Contributor

@zeroZshadow zeroZshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new helper method is good, but the updated test seems wrong?
I'm sure we have other tests that remove entities instead.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jamiebrynes7 jamiebrynes7 merged commit 3dc4c53 into develop May 22, 2020
@improbable-prow-robot improbable-prow-robot deleted the chore/make-martijn-happy branch May 22, 2020 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants